Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Appearance of the check in a checked box #3048

Closed
7 tasks done
daniellecorke opened this issue Feb 22, 2024 · 1 comment · Fixed by #3066
Closed
7 tasks done

[Bug] Appearance of the check in a checked box #3048

daniellecorke opened this issue Feb 22, 2024 · 1 comment · Fixed by #3066
Assignees
Labels
Bug Something isn't working Component A component in the ONS Design System

Comments

@daniellecorke
Copy link

daniellecorke commented Feb 22, 2024

Background/Issue

A user reported this issue via the Slack channel.

Something minor which I noticed: the check inside a checked checkbox seems to display oddly in Safari on the Mac (there's a gap between the joining lines). It appears differently at different zoom levels. Seems to be using an ::after pseudo-element with bottom and right borders, rotated, to form a tick. Haven't tested in Chrome, Firefox or Edge.

The user was accessing the Accordian component (open) example.

Example

Screen.Recording.2024-02-22.at.10.39.11.mov

Tasks

  • Try to replicate the issue using Safari
  • Try to replicate the issue using Chrome, Firefox and Edge
  • Identify the cause of the issue and a potential fix
  • If possible, implement the fix
  • PM to update the user(s)

Acceptance Criteria

  • If possible, a fix is applied to resolve the issue for all applicable web browsers
  • PM has updated the user(s)
@daniellecorke daniellecorke added Bug Something isn't working Component A component in the ONS Design System labels Feb 22, 2024
@JNATION85
Copy link
Contributor

If you remove the border-radius on the pseudo element it will fix the issue. The visual aspect doesn't get compromised either so happy to implement this

@adi-unni adi-unni self-assigned this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Component A component in the ONS Design System
Projects
None yet
3 participants