Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exploring Unnecessary Conditionals: Label #3022

Closed
3 tasks
balibirchlee opened this issue Feb 1, 2024 · 0 comments · Fixed by #3108
Closed
3 tasks

Exploring Unnecessary Conditionals: Label #3022

balibirchlee opened this issue Feb 1, 2024 · 0 comments · Fixed by #3108
Assignees
@SriHV
Labels
Enhancement Change of existing feature

Comments

@balibirchlee
Copy link
Contributor

Component contains conditionals around params.for on line 25 - which is a required parameter.

Actions

  • Establish if this is superfluous or necessary code.
  • Remove if not necessary.
  • Ensure testing remains intact / update testing as required.
@daniellecorke daniellecorke added the Enhancement Change of existing feature label Feb 8, 2024
@SriHV SriHV self-assigned this Mar 21, 2024
@SriHV SriHV mentioned this issue Mar 21, 2024
Merged
2 tasks
@SriHV SriHV linked a pull request Mar 21, 2024 that will close this issue
Enhancement/3022/explore unnecessary conditionals label #3108
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SriHV SriHV

Labels
Enhancement Change of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhancement/3022/explore unnecessary conditionals label ONSdigital/design-system
3 participants
@daniellecorke @SriHV @balibirchlee