Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exploring Unnecessary Conditionals: Header #3021

Closed
3 tasks
balibirchlee opened this issue Feb 1, 2024 · 0 comments · Fixed by #3112
Closed
3 tasks

Exploring Unnecessary Conditionals: Header #3021

balibirchlee opened this issue Feb 1, 2024 · 0 comments · Fixed by #3112
Assignees
@SriHV
Labels
Enhancement Change of existing feature
Milestone
Deliver new itera...

Comments

@balibirchlee
Copy link
Contributor

Component contains references to item.iconType, item.title, and siteSearchAutosuggest which are not in the markdown file.

Actions

  • Establish if this is legacy code or else is created elsewhere - double bracket to see if the param has a value.
  • Remove if not necessary.
  • Ensure testing remains intact / update testing as required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SriHV SriHV

Labels
Enhancement Change of existing feature
Projects
None yet
Milestone
Deliver new iterations of the Design ...
Development

Successfully merging a pull request may close this issue.

Exploring Unnecessary Conditionals: Header ONSdigital/design-system
3 participants
@daniellecorke @SriHV @balibirchlee