Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Icon in the template footer are not clickable #3004

Closed
alessioventuriniAND opened this issue Jan 26, 2024 · 2 comments · Fixed by #3036
Closed

[Bug]: Icon in the template footer are not clickable #3004

alessioventuriniAND opened this issue Jan 26, 2024 · 2 comments · Fixed by #3036
Assignees
Labels
Bug Something isn't working Community backlog An issue raised on the community backlog Refined(Tech) Refined during tech refinement session

Comments

@alessioventuriniAND
Copy link
Contributor

alessioventuriniAND commented Jan 26, 2024

What happened?

The icon in the footer are not clickable. This has been highlighted as an accessibility issue in the Dac report of the IDS website.

What was the expected outcome?

Icon in the footer to be clickable.

How is this problem impacting your service?

accessibility failing

What list of steps can be followed to reproduce the bug or issue?

You can look into the IDS live website and when trying to click on the icons in the footer they are not clickable.

Example

No response

What version of the ONS Design System are you using?

67.0.4

What devices are you seeing the problem on?

Desktop, Mobile, Tablet

Device details

No response

What operating systems are you seeing the problem on?

No response

Operating system details

No response

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge, Microsoft Internet Explorer

Browser details

No response

@alessioventuriniAND alessioventuriniAND added Bug Something isn't working Community backlog An issue raised on the community backlog Refined(Tech) Refined during tech refinement session labels Jan 26, 2024
@alessioventuriniAND
Copy link
Contributor Author

We need to be able to add links around the icon in the footer.

@balibirchlee
Copy link
Contributor

As the custom poweredBy accepts HTML and the IDS website is using this to render a more complicated set up than a simple icon image - it has been agreed that IDS would instead add the links to their existing html. Any other implementation would result in a breaking change, requiring either IDS to simplify their existing footer (i.e. providing only an image) or us to scope an enhancement to the current footer modelled after IDS's current set up.

Whether ourselves or IDS feel that this enhancement should be made is up for discussion, but is beyond the scope of this ticket.

As such, the ticket has been adjusted to focus on providing links for the existing default ONS icons which are responsive to the language selection (i.e. the Welsh language version which renders the Welsh variant of the default icon has a link to the Welsh site, and vice versa for the English language version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Community backlog An issue raised on the community backlog Refined(Tech) Refined during tech refinement session
Projects
None yet
4 participants