Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML not being minified causing extra whitespace #2873

Closed
rmccar opened this issue Oct 25, 2023 · 2 comments · Fixed by #2958
Closed

HTML not being minified causing extra whitespace #2873

rmccar opened this issue Oct 25, 2023 · 2 comments · Fixed by #2958
Assignees
Labels
Bug Something isn't working

Comments

@rmccar
Copy link
Contributor

rmccar commented Oct 25, 2023

HTML not being minified is causing extra whitespace such as in this example here. You can see there is a gap between the text and the padding that I don't think should be there. This is also an issue on header service links.
I found this on this example on the service manual

Screenshot 2023-10-25 at 12 40 39

This might be something that we can look to solve using the {- -} syntax in Nunjucks but probably needs some investigation into this and how much of an issue it is and if minifying causes any other issues. Then some investigation on the best way to do it if we do decide to do it and which tools we can use.

@rmccar rmccar changed the title HTML not being minimised causing extra whitespace HTML not being minified causing extra whitespace Oct 25, 2023
@rmccar rmccar added the Bug Something isn't working label Oct 25, 2023
@yatesn
Copy link

yatesn commented Oct 26, 2023

Needs investigating to work out best option

@yatesn
Copy link

yatesn commented Nov 16, 2023

Links to #2088

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants