Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase banner placement guidance incorrect and shares same background as cookie banner #2325

Closed
jrbarnes9 opened this issue Jul 14, 2022 · 3 comments · Fixed by #2678
Closed
Assignees
Labels
Accessibility Issues discovered through accessibility testing Documentation Documentation content or feature for the design system website Enhancement Change of existing feature

Comments

@jrbarnes9
Copy link
Contributor

jrbarnes9 commented Jul 14, 2022

Phase banner has no landmark role so it should be placed within <header> to be contained within the same, single "banner" landmark. This is the case when using base page template, but if not, the guidance only states:

The phase banner must be placed directly above the ONS header at the very top of the page.

...so it's not clear that it should be within {% block header %}

It also shares the same background as cookie banner so there is no distinction between the two banners.

Screenshot 2022-07-14 at 15 09 29

Originally posted by @jrbarnes9 in #8 (comment)

@jrbarnes9 jrbarnes9 added the Enhancement Change of existing feature label Jul 14, 2022
@jrbarnes9 jrbarnes9 changed the title Phase banner shares same background as cookie banner Phase banner has no landmark role or accessible name, and shares same background as cookie banner Jul 14, 2022
@jrbarnes9 jrbarnes9 added the Accessibility Issues discovered through accessibility testing label Jul 14, 2022
@jrbarnes9 jrbarnes9 changed the title Phase banner has no landmark role or accessible name, and shares same background as cookie banner Phase banner is not contained within any landmark and shares same background as cookie banner Jul 14, 2022
@jrbarnes9 jrbarnes9 changed the title Phase banner is not contained within any landmark and shares same background as cookie banner Phase banner placement guidance incorrect and shares same background as cookie banner Jul 14, 2022
@jrbarnes9 jrbarnes9 removed the Accessibility Issues discovered through accessibility testing label Jul 14, 2022
@yatesn yatesn added Accessibility Issues discovered through accessibility testing Documentation Documentation content or feature for the design system website labels Feb 9, 2023
@yatesn
Copy link

yatesn commented Feb 9, 2023

Documentation aspect has been done

@alessioventuriniAND
Copy link
Contributor

Do we need to update the colour of the phase banner? @emilymaylawes can you please advice on this?

I have checked the documentations and it's now clear where to place the phase banner within the layout . Below if the doc reference :

Base page template
The phase banner component can be added to the top of the header using the base page template.

You can override this by manually adding it using the header block.

@emilymaylawes
Copy link

Design pushed into change looks like the below

Image

Replacing the phase banner background colour with white, and adding a 1px bottom border with var(--ons-color-borders) to distinguish from both the cookie banner and the top section of the header that holds the ONS logo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues discovered through accessibility testing Documentation Documentation content or feature for the design system website Enhancement Change of existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants