Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken html in Table of Contents example #1790

Closed
jrbarnes9 opened this issue Dec 2, 2021 · 0 comments · Fixed by #1791
Closed

Broken html in Table of Contents example #1790

jrbarnes9 opened this issue Dec 2, 2021 · 0 comments · Fixed by #1791
Labels
Bug Something isn't working

Comments

@jrbarnes9
Copy link
Contributor

jrbarnes9 commented Dec 2, 2021 •
edited
Loading

The example contains broken html; there's a closing </aside> tag but no opening. I've implemented the sticky TOC on the ONS website and have added the containing css class ons-toc-container to the <aside> but I am essentially overriding all the properties within:

.ons-toc-container {
  border-bottom: none;
  margin-bottom: 0;
  padding-bottom: 0;
}

Originally posted by @mr-nick17 in #1382 (comment)
@jrbarnes9 jrbarnes9 added the Bug Something isn't working label Dec 2, 2021
@jrbarnes9 jrbarnes9 linked a pull request Dec 2, 2021 that will close this issue
Fixed sticky Table of Contents invalid html #1791
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed sticky Table of Contents invalid html ONSdigital/design-system
1 participant
@jrbarnes9