Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checkboxes and radios as input types for the 'other' conditional reveal variant for radios and checkboxes components #1648

Closed
jrbarnes9 opened this issue Aug 18, 2021 · 0 comments · Fixed by #1732
Closed

Add checkboxes and radios as input types for the 'other' conditional reveal variant for radios and checkboxes components #1648

jrbarnes9 opened this issue Aug 18, 2021 · 0 comments · Fixed by #1732
Assignees
@boxadesign
Labels
Component A component in the ONS Design System Enhancement Change of existing feature

Comments

@jrbarnes9
Copy link
Contributor

jrbarnes9 commented Aug 18, 2021 •
edited
Loading

Add checkboxes and radios as input types for the 'other' conditional reveal variant for radios and checkboxes components.

To do:

  • Add checkboxes and radios inputs as conditionally revealed 'other' variant of radios and checkboxes
  • Add usage rationale
  • Ensure both bordered and borderless variants can cater for conditionally revealed inputs, radios and checkboxes
    • Add border and indent style for all the revealed 'other' inputs when used with borderless variant (see screenshot)

Screenshot 2021-08-18 at 15 54 35

Screenshot 2021-08-24 at 16 44 27

Originally posted by @jrbarnes9 in #56 (comment)
@jrbarnes9 jrbarnes9 added Component A component in the ONS Design System Enhancement Change of existing feature labels Aug 18, 2021
@jrbarnes9 jrbarnes9 mentioned this issue Aug 31, 2021
Closed
@boxadesign boxadesign self-assigned this Oct 5, 2021
@boxadesign boxadesign linked a pull request Oct 13, 2021 that will close this issue
Checkboxes/radios - Add select all and allow under 'other' reveal #1732
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boxadesign boxadesign

Labels
Component A component in the ONS Design System Enhancement Change of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Checkboxes/radios - Add select all and allow under 'other' reveal ONSdigital/design-system
2 participants
@boxadesign @jrbarnes9