Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nazara (BA:RET11) - Compliance Check #2916

Open
Jagannath-wits opened this issue Dec 10, 2024 · 1 comment
Open

Nazara (BA:RET11) - Compliance Check #2916

Jagannath-wits opened this issue Dec 10, 2024 · 1 comment

Comments

@Jagannath-wits
Copy link

Jagannath-wits commented Dec 10, 2024

Nazara

  • Buyer app should nack for the following seller issues

Flow 1

search

  • bap_terms is not required for now.
  • transaction_id and message_id cannot be the same.

on_search

  • City code mismatch between search and on_search.
  • bap_id and uri should not be empty in the context.
  • Message IDs for /search and /on_search API should be the same.
  • Transaction IDs for /search and /on_search API should be the same.
  • Either fixed (range) or split (frequency and times) timings should be provided in /bpp/providers[0]/locations[0]/time.
  • Customizable items must have a default selection price:
    • items[68ae0d64-a8a7-412a-a359-007ffac25eaa]/price/tags/default_selection missing.
  • Customizable items must have a lower/upper price range:
    • items[68ae0d64-a8a7-412a-a359-007ffac25eaa]/price/tags/lower_and_upper_range missing.
  • For standalone SKUs, the type tag is optional:
    • items[c8314c6d-8365-4f72-92f8-d89ec23291f1].
  • Timestamp for item[0] cannot be greater than context.timestamp.
  • Both providers cannot have the same fulfillment_id.
  • provider[0].tags.timing.location.id is invalid and not provided in provider[0].locations.id.
  • Items must have lower/upper range for customizable items.
  • tags/'type' is optional for standalone SKUs.

search_inc

  • transaction_id and message_id cannot be the same.
  • context/city should be "*" while sending search_inc_catalog request.

on_search_inc

  • locationTimeLabel should not match /on_search_full_catalog_refresh.label.
  • only delta changes should be provided in inc_on_search
  • Duplicate item:
    • "Similar Item as in /on_search_full_catalog_refresh API call, item ID: i1."

Flow 2

select

  • items.id and locations.id do not match with on_search. How are orders being placed?

on_select

  • City code mismatch between /search and /on_select.
  • Invalid @ondc/org/category in fulfillment0. Should be "Immediate Delivery" for "F&B".

on_confirm

  • Time ranges should only be provided in on_confirm when the order state is "Accepted".
  • np_type is missing in message/order/tags/bpp_terms for on_confirm.
  • provider_tax_number must be present for on_confirm.

on_status_picked

  • /message/order must have the required property documents.

on_status_delivered

  • /message/order must have the required property documents.
  • Tags are mandatory in delivery fulfillment for on_status_delivered.
  • Delivery timestamp is missing.

Flow 4

on_cancel

  • Items object not updated properly
  • No need to add -0.00 items in the quote trail.
  • Why is the seller charging packaging and delivery charges when the order is cancelled pre-shipment

Flow 5

on_status_pending

  • Order state should be "Accepted".

on_cancel

  • quote_trail shouldn’t be provided in delviery fulfillment
  • Message id should not be same with previous calls
  • Total item count in message/order/items doesn't match with item count of /on_select
  • precancel_state.updated_at of on_status_rto_delivered/disposed is not equal with the on_status_out_for_delivery order.updated_at
  • items object not updated properly

@pankajkumar3

@FarheenNazz
Copy link

FarheenNazz commented Dec 24, 2024

Nazara

  • Buyer should send NACK for the following -

Flow1

On Search

  • message.catalog["bpp/providers"][0].category_id >> Unnecessary category_id is provided.
  • accept_bap_terms is not required in the bpp/descriptor/tags/bpp_terms for now as it is not enabled yet
  • No items are mapped with the given category_id 128095 in providers0/items
  • /message/catalog/bpp/providers/items[0]tags/'type' is optional for non-customizable (standalone) SKUs (check for others as well)
  • /message/catalog/bpp/providers/items[0] timestamp can't be greater than context.timestamp (check for others as well)
  • emptyy timing array is not required message/catalog/bpp/providers/items[0].tags (check for others as well)

Search Inc

  • Static terms are not required in the search inc call.

On Search Inc

  • Invalid incremental call. Please provide a valid payload with proper incremental changes.

Flow2

Select

  • Timestamp for /on_search api cannot be greater than or equal to /select api

On Select

  • /message/order/quote/breakup/item/quantity/available/count available count must be either 99 or 0 only

On_init

  • Invalid field provided i.e. mesage.order.provider_location
  • message.order.quote.breakup[2].item.quantity, available and maximum should not be provided after on_select action call
  • message/order must have required property 'tags'
  • empty message.order.add_ons should not be provided
  • empty message.order.offers should not be provided.

Confirm

  • message.order.tags[0] >> BPP terms are missing; "None" is provided in the same object.

on_status_picked

  • message/order must have required property 'documents'

Flow 3

On Select Out Of Stock

  • The error.message provided in the on_select_out_of_stock should be in the form of an array with proper error_code and item_id
  • Item's unit and total price mismatch for id: 2455680, how the tax and packing charges are being added for the item if the quantity is zero ?

Flow 4

On Cancel

  • Message id for cancel and on_cancel should be same
  • message/order/fulfillments/0/start/location/address/area_code must NOT have more than 6 characters (letters mentioned here)
  • Invalid Quote Trail Type 'discount' value i.e --39.
  • backward fulfillment for the cancellation is missing in the items

Flow 5

On Status RTO Delivered

  • fulfillment type delivery start/time is missing in /on_status_rto_delivered/disposed
  • fulfillment type RTO start object location and end object is missing in /on_status_rto_delivered/disposed
  • context.action should be on_status (on_cancel mentioned)

Kindly provide flow 6 for validation

Flow 7

catalog_rejection

  • Catalog rejection error message doesn't match with the provided error.message code: 9xxx1
  • Incorrect context timestamp format

Flow 9

on_search

  • Wrong payload provided for this call

catalog_rejection

  • Catalog rejection error message doesn't match with the provided error.message code: 9xxx1
  • Incorrect context timestamp format

@pankajkumar3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants