Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: integration with Broadsea 3.0 #50

Open
alondhe opened this issue Jul 7, 2023 · 6 comments
Open

Proposal: integration with Broadsea 3.0 #50

alondhe opened this issue Jul 7, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@alondhe
Copy link
Contributor

alondhe commented Jul 7, 2023

As discussed with @leeevans, we'd like to add Perseus services to Broadsea. This would simply leverage Perseus docker images, not alter Perseus in any way.

With Broadsea 3.0, we use traefik as a proxy, so the idea would be to add Perseus services and middlewares that allow them to work with all other services in Broadsea.

image
@alondhe
Copy link
Contributor Author

alondhe commented Jul 13, 2023

I'll need to amend my earlier statement: some alterations to Perseus may be needed, but ones that I think are useful.

  1. Allow for the environment.serverUrl to be set externally, rather than set statically (https://nkpremices.com/dynamically-set-angular-env-variables-in-docker/)
  2. Allow for using the Broadsea Solr and PG Vocab instead of using the one from Perseus, to avoid duplication.

@natb1
Copy link
Collaborator

natb1 commented Jul 13, 2023

Hi @alondhe, there's an issue template for this kind of thing - not to be bureaucratic, just to point out for example:

Provide a plan for executing/sponsoring the implementation and maintenance of the proposal.

Without this the only vehicle for support is the time I volunteer for the Perseus users group.

@leeevans
Copy link
Collaborator

leeevans commented Jul 13, 2023

Hi @natb1

Do we need to create a new issue to use the template? I’m happy to do that if that’s the recommended approach. I can also work on the plan.

@natb1
Copy link
Collaborator

natb1 commented Jul 13, 2023

I don't care about using the template as much as I think you'll have more luck finding support if we know who is providing the support and by what mechanism. There are no volunteers that I know of working on the project currently (other than my time on the user group). I'd be happy to help sort through the additional questions from the template if I just knew who was asking me to do it.

@leeevans
Copy link
Collaborator

Ok @natb1

FYI. I’m working with @alondhe on the Perseus integration with Broadsea 3.0, so I’ll follow up with the Perseus development team on this issue.

@alondhe
Copy link
Contributor Author

alondhe commented Jul 18, 2023

Hi @natb1 -- apologies for the deviation from the prompts. As @leeevans said, we'll be leading this effort, with help from @bradanton for any PRs (like #52).

Here's the latest:

  1. All services are running on our traefik proxy /perseus, with each having a container name that has "perseus-" prefix
  2. The frontend now (once we have the new docker hub image posted) can be used for Broadsea, as it has a special angular build that sets the base-href and the serverUrl
  3. For the flask based containers, I can replace the config.py files at container startup to work with our new service names (e.g. perseus-files-manager instead of files-manager).
  4. The main technical challenge remaining is the CDM-Builder, as I raised here: CDM-Builder app settings question #53. Can we send env variables to modify the various service name dependencies, or do we need to create a new appsettings json file for the build?

@ssamus ssamus added the enhancement New feature or request label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

5 participants