msbuild /t:restore refuses to restore one particular project from a solution

[davkean]

RTM

1. Clone https://github.com/davkean/roslyn-project-system
2. Open VS Command Prompt
3. > git checkout 6e9c5158b279919226c58a5289a81bf0ef8f8964
4. > git clean -dxf
5. > build.cmd

Expected: No build errors
Actual:

E:\project-system2\src\Common\ProvideBindingRedirectionAttribute.cs(12,77): error CS0246: The type or namespace name 'RegistrationAttribute' could not be found (are you missing a using directive or an assembly reference?) [E:\project-system2\src\ProjectSystemSetup\ProjectSystemSetup.csproj]
AssemblyRedirects.cs(5,12): error CS0616: 'ProvideProjectSystemBindingRedirectionAttribute' is not an attribute class [E:\project-system2\src\ProjectSystemSetup\ProjectSystemSetup.csproj]
AssemblyRedirects.cs(6,12): error CS0616: 'ProvideProjectSystemBindingRedirectionAttribute' is not an attribute class [E:\project-system2\src\ProjectSystemSetup\ProjectSystemSetup.csproj]
AssemblyRedirects.cs(7,12): error CS0616: 'ProvideProjectSystemBindingRedirectionAttribute' is not an attribute class [E:\project-system2\src\ProjectSystemSetup\ProjectSystemSetup.csproj]
AssemblyRedirects.cs(8,12): error CS0616: 'ProvideProjectSystemBindingRedirectionAttribute' is not an attribute class [E:\project-system2\src\ProjectSystemSetup\ProjectSystemSetup.csproj]
AssemblyRedirects.cs(9,12): error CS0616: 'ProvideProjectSystemBindingRedirectionAttribute' is not an attribute class [E:\project-system2\src\ProjectSystemSetup\ProjectSystemSetup.csproj]
AssemblyRedirects.cs(10,12): error CS0616: 'ProvideProjectSystemBindingRedirectionAttribute' is not an attribute class [E:\project-system2\src\ProjectSystemSetup\ProjectSystemSetup.csproj]
E:\project-system2\src\Common\ProvideBindingRedirectionAttribute.cs(11,6): error CS0641: Attribute 'AttributeUsage' is only valid on classes derived from System.Attribute [E:\project-system

If you look in bin\obj\ProjectSystemSetup - you'll notice that no assets/props files were generated.

Note, if I open the solution in VS and use VS's restore - the project is restored as normal.

Attached is the Restore log:
Restore.zip

Note, this only occurred after the code changes in this PR: dotnet/project-system#1784. It appears removing another project from the solution caused this.

[davkean]

Note, this was resolved on our side by removing an explicit dependency in the SLN from ProjectSystemSetup -> VisualStudioEditorsSetup: dotnet/project-system@e1a1d99, but there's still a bug here.

[davkean]

This is a dup of #4578.