Skip to content
This repository was archived by the owner on Nov 26, 2020. It is now read-only.

react-native run-android fails in task ":react-native-nfc:compileReleaseJavaWithJavac" #19

Open
MajPay opened this issue Nov 14, 2017 · 6 comments

Comments

@MajPay
Copy link

MajPay commented Nov 14, 2017

Hello,

i just installed your module in my react-native app. When running react-native run-android, an error occurs.

The task that fails: :react-native-nfc:compileReleaseJavaWithJavac

The error:

ReactNativeNFCPackage.java:21: error: method does not override or implement a method from a supertype
@Override

The following information may be of some help to you:

Environment:
  OS:  Linux 4.10
  Node:  7.10.0
  Yarn:  1.2.1
  npm:  4.2.0
  Watchman:  4.9.0
  Xcode:  N/A
  Android Studio:  Not Found

Packages: (wanted => installed)
  react: 16.0.0-beta.5 => 16.0.0-beta.5
  react-native: 0.49.3 => 0.49.3
@MajPay
Copy link
Author

MajPay commented Nov 14, 2017

Okay - i am completely new to app development and dont know anything about java, so my shots are in the dark:

It seems the interface changed, the method createJSModules is not needed anymore by ReactPackage. When i remove that method i receive a different error. I figured out the folder structure also changed, so the file "nfc_tech_filter.xml" needs to be present in the path ./android/app/src/main/res/xml

Once this is fixed too the app builds. I doubt it will all work now because i basically just removed code... I would say this package is not compatible to newer versions of react-native.

@tsvetann
Copy link

I have the same problem. This package is not working anymore.

@M1chaelTran
Copy link

M1chaelTran commented Dec 11, 2017

the exact same issue here.

I managed to resolve it by commenting it out

    // Deprecated RN 0.47
    // @Override

@ascorbic
Copy link

ascorbic commented Jan 4, 2018

The fix for this is in git, but not in npm. Could you push a release?

@NonkelDaniel
Copy link

I am having the same problem, is it possible to publish the fix for this? Commenting out the @OverRide might be a valid temporary solution but it should be fixed in the package as well please!

@tehzwen
Copy link

tehzwen commented Oct 17, 2018

Good call on commenting out the override, worked like a charm!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants