Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting the contents of the entry does not uncollapse the contents #76

Closed
NorfairKing opened this issue Jun 12, 2020 · 4 comments
Closed
Labels
good first issue Good for newcomers

Comments

@NorfairKing
Copy link
Owner

Peek 2020-06-12 15-10

@gltronred
Copy link
Contributor

There are bools for parts that can be collapsed, but no corresponding actions in Smos.Action.*: https://github.com/NorfairKing/smos/blob/master/smos-cursor/src/Smos/Cursor/Collapse.hs

I will add actions and bind them to z<char> (https://vim.fandom.com/wiki/Folding):

  • zc - toggle contents visibility
  • zh - toggle history visibility
  • zl - toggle logbook visibility

@gltronred
Copy link
Contributor

Actions for collapsing parts of entry are ready. But they do not solve the problem with selecting collapsed entry.

I think that correct solution would be to forbid selecting contents if it is hidden. But it seems to be a lot of work to implement it

@NorfairKing
Copy link
Owner Author

I think that correct solution would be to forbid selecting contents if it is hidden. But it seems to be a lot of work to implement it

You could auto-unfold the contents if the contents aren't selected. That's the way it works with making an entry below the current entry right now.

@NorfairKing NorfairKing added the good first issue Good for newcomers label Jun 13, 2020
@NorfairKing
Copy link
Owner Author

This is now fixed on development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants