-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gdal: 3.8.5 -> 3.9.0 #311310
gdal: 3.8.5 -> 3.9.0 #311310
Conversation
|
Result of 4 packages marked as broken and skipped:
75 packages failed to build:
31 packages built:
|
Challenges: - Upgrade GDAL to <3.9 because of <NixOS/nixpkgs#311310>. - Upgrade numexpr to <2.10 because of <NixOS/nixpkgs#310837>. - Had to add Cython 0 to the color-operations build inputs <nix-community/poetry2nix#1658>
What is the status of this? I see lots of failures in your build report. Would be nice to get this in 24.05, but branch-off is imminent. |
Too many packages failed to build - mostly tests are failing. I think we can't get it in to 24.05. |
Result of 6 packages marked as broken and skipped:
41 packages failed to build:
67 packages built:
Logs
|
Challenges: - Had to hold back GDAL from 3.9 because it's not yet in nixpkgs <NixOS/nixpkgs#311310>. - Had to hold back numexpr from 2.10 because it's not yet in nixpkgs <NixOS/nixpkgs#310837>. - Had to hold back matplotlib from 3.9 because it needs a poetry2nix override <nix-community/poetry2nix#1659>. - Had to force sat-search version 0.3.0 to avoid Poetry downgrading it to 0.1.0. - Had to add Cython 0 to the color-operations build inputs <nix-community/poetry2nix#1658>. Script: ```bash cd flooding/sentinel2_water_extraction poetry add --lock gdal="<3.9" matplotlib="<3.9" numexpr="<2.10" sat-search=">=0.3.0" poetry update --lock git checkout pyproject.toml poetry lock --no-update cd ../sentinel1_water_extraction/ poetry add --lock gdal="<3.9" poetry update --lock git checkout pyproject.toml poetry lock --no-update ```
Challenges: - Had to hold back GDAL from 3.9 because it's not yet in nixpkgs <NixOS/nixpkgs#311310>. - Had to hold back numexpr from 2.10 because it's not yet in nixpkgs <NixOS/nixpkgs#310837>. - Had to hold back matplotlib from 3.9 because it needs a poetry2nix override <nix-community/poetry2nix#1659>. - Had to force sat-search version 0.3.0 to avoid Poetry downgrading it to 0.1.0. - Had to add Cython 0 to the color-operations build inputs <nix-community/poetry2nix#1658>. Script: ```bash cd flooding/sentinel2_water_extraction poetry add --lock gdal="<3.9" matplotlib="<3.9" numexpr="<2.10" sat-search=">=0.3.0" poetry update --lock git checkout pyproject.toml poetry lock --no-update cd ../sentinel1_water_extraction/ poetry add --lock gdal="<3.9" poetry update --lock git checkout pyproject.toml poetry lock --no-update ```
Result of 4 packages marked as broken and skipped:
49 packages failed to build:
85 packages built:
|
Result of 4 packages marked as broken and skipped:
47 packages failed to build:
95 packages built:
|
Result of 4 packages marked as broken and skipped:
142 packages built:
|
@sikmir , this PR is ready for review now and please run nixpkgs-review on Darwin if you can. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, and the comments are fantastic! Actionable comments for temporary workarounds FTW.
Build in progress |
From Geospatial Team Matrix """ |
Rebased with current master. |
Result of 6 packages marked as broken and skipped:
144 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent job, thanks!
Nixpkgs PR: NixOS/nixpkgs#311310
Challenges: - Had to hold back GDAL from 3.9 because it's not yet in nixpkgs <NixOS/nixpkgs#311310>. - Had to hold back numexpr from 2.10 because it's not yet in nixpkgs <NixOS/nixpkgs#310837>. - Had to hold back matplotlib from 3.9 because it needs a poetry2nix override <nix-community/poetry2nix#1659>. - Had to force sat-search version 0.3.0 to avoid Poetry downgrading it to 0.1.0. - Had to add Cython 0 to the color-operations build inputs <nix-community/poetry2nix#1658>. Script: ```bash cd flooding/sentinel2_water_extraction poetry add --lock gdal="<3.9" matplotlib="<3.9" numexpr="<2.10" sat-search=">=0.3.0" poetry update --lock git checkout pyproject.toml poetry lock --no-update cd ../sentinel1_water_extraction/ poetry add --lock gdal="<3.9" poetry update --lock git checkout pyproject.toml poetry lock --no-update ```
Description of changes
Update GDAL to the latest version.
Release notes: https://github.com/OSGeo/gdal/blob/v3.9.0/NEWS.md
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.