Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timeline: 2.4.0 -> 2.6.0, fix build #162503

Merged
merged 1 commit into from
Mar 14, 2022
Merged

timeline: 2.4.0 -> 2.6.0, fix build #162503

merged 1 commit into from
Mar 14, 2022

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Mar 2, 2022 •
edited
Loading

Motivation for this change

The package did not build. Now it does, but it crashes with

(.timeline-wrapped:2422797): GLib-GIO-ERROR **: 17:05:40.072: No GSettings schemas are installed on the system
Trace/breakpoint trap (core dumped)

I tried adding wrapGAppsHook, gsettings-desktop-schemas, and glib, but none of those fixed it.

Any ideas?

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from davidak March 2, 2022 16:24
@davidak
Copy link
Member

davidak commented Mar 3, 2022 •
edited
Loading

The situation with wxPython is a total mess. Maybe that's related.

#135607
#90654

Also see http://thetimelineproj.sourceforge.net/changelog.html#version-2-6-0

Dependencies:

Removed dependency on Pillow/PIL since it is no longer used.
Removed dependency on pysvg since it is no longer used.

@fgaz fgaz force-pushed the timeline/2.6.0 branch from 54460e0 to 5f69cf0 Compare March 3, 2022 19:07
@fgaz
Copy link
Member Author

fgaz commented Mar 3, 2022

I removed the unused packages

@fgaz
Copy link
Member Author

fgaz commented Mar 14, 2022

Can we merge this? Though there's still that crash, at least now the package builds

@davidak
Copy link
Member

davidak commented Mar 14, 2022

Result of nixpkgs-review pr 162503 run on x86_64-linux 1

1 package built:
  • timeline

davidak
davidak approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good

Builds, works (for me)

@davidak davidak merged commit 4c55481 into NixOS:master Mar 14, 2022
@davidak
Copy link
Member

davidak commented Mar 14, 2022

@fgaz It does not crash on my system (Pantheon desktop). Can you create an issue for the crash. Maybe we can investigate what caused it. What is your desktop?

@fgaz fgaz mentioned this pull request Mar 14, 2022
Closed
@fgaz
Copy link
Member Author

fgaz commented Mar 14, 2022

I'm running awesome. Ticket: #164127

@fgaz fgaz deleted the timeline/2.6.0 branch March 14, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgaz @davidak