Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxwidgets: 3.1.4 -> 3.1.5 #161593

Closed
wants to merge 1 commit into from
Closed

Conversation

wentasah
Copy link
Contributor

Motivation for this change

KiCad fails to build against wxwidgets 3.1.4. It needs 3.1.5. See https://hydra.nixos.org/build/167894401.

Cc: @evils @Kiwi (KiCad maintainers)

The changelog is here.

Tested by running KiCad.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@evils
Copy link
Member

evils commented Feb 24, 2022

it's already in staging-next
https://nixpk.gs/pr-tracker.html?pr=157848

also, just giving kicad wxpython 4.1.1 and wxwidgets 3.1.5 doesn't entirely work
#135607 (comment)

@wentasah
Copy link
Contributor Author

Ah, OK. I didn't notice that. I'm closing this and waiting for the other PR to propagate further. Thanks.

@wentasah wentasah closed this Feb 24, 2022
@wentasah wentasah deleted the wxwidgets-3.1.5 branch May 3, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants