wxGTK31: 3.1.4 -> 3.1.5 #157848
Merged
wxGTK31: 3.1.4 -> 3.1.5 #157848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Feb 3, 2022
There was a problem hiding this comment.
might not be relevant, but probably good to tackle now:
error: builder for '/nix/store/kxih50jb28xn8swyf5vn9nc8bld9lrym-wxwidgets-3.0.5.drv' failed with exit code 1;
last 10 log lines:
> applying patch /nix/store/71qmb62m4m5zl947jx53y98jakdjzycx-0001-fix-assertion-using-hide-in-destroy.patch
> patching file src/common/toplvcmn.cpp
> Hunk #1 succeeded at 124 (offset 2 lines).
> configuring
> fixing libtool script ./src/png/ltmain.sh
> fixing libtool script ./src/tiff/config/ltmain.sh
> fixing libtool script ./src/jpeg/ltmain.sh
> fixing libtool script ./src/expat/expat/conftools/ltmain.sh
> configure flags: --disable-dependency-tracking --prefix=/nix/store/yymqxrldmabpqnr6qa9svp90905xc197-wxwidgets-3.0.5 --disable-precomp-headers --enable-mediactrl --disable-compat24 --enable-compat26 --enable-unicode --with-opengl
> configure: error: unrecognized options: --disable-compat24, --enable-compat26
For full logs, run 'nix log /nix/store/kxih50jb28xn8swyf5vn9nc8bld9lrym-wxwidgets-3.0.5.drv'.
KoviRobi
reviewed
Feb 23, 2022
Comment on lines
+20556
to
+20557
| wxGTK31-gtk2 = wxGTK30.override { withGtk2 = true; }; | ||
| wxGTK31-gtk3 = wxGTK30.override { withGtk2 = false; }; |
There was a problem hiding this comment.
Is this a typo that's meant to be wxGTK31.override? (I can open a separate MR, just trying to get kicad working)
There was a problem hiding this comment.
Yep, I left that escape :/
|
this didn't have to go into staging |
|
Originally it triggered red flags about many builds on master. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes