-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging next #118312
Merged
Merged
Staging next #118312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regex should match files ending in `.git`, not any character and `git` after that.
The build wanted to create a Cargo.lock in the top-level source directory (presumably because it is also a Cargo project), since we were crating the lock file in sourceRoot (which was set to the example project). This failed because the sources are read-only. Change the test to create the lock file in the top-level crate directory, which is Cargo's default behavior.
The passthru test used python3Packages, mixing different Python version when testing on a Python version different that the python3 alias.
networkmanager: 1.30.0 -> 1.30.2
[staging] python3Packages.django_2: 2.2.18 -> 2.2.19
xorg.xorgproto: 2020.1 -> 2021.3
fetchgit: escape dot in regex
imagemagick: 7.0.11-3 -> 7.0.11-4
When, after patching, `configure.ac` is newer than `configure`, the Makefile will try to regenerate `configure` from `configure.ac`. While that might usually be desirable, in this case we want to keep bootstrapping simple and directly use the `configure` from the package so we can avoid a dependency on automake. Previously, we used the `-T` parameter to automake to make sure the timestamps were okay. However, this is brittle when we update: when the timestamp of the original file changes, and no longer matches the timestamp of the original file in the patch, `patch` will show a warning but otherwise continue without updating the timestamp. This PR changes things so we only patch `configure`, so that will always have a newer timestamp. Refs #115177
ntfs3g: add darwin build
The applied patch contains the changes from this PR: OpenMathLib/OpenBLAS#3060 This patch prevents gcc from reordering instructions in a way that can cause crashes with SIGILL on aarch64. This issue crashes python when importing numpy on aarch64: numpy/numpy#18131
Get rid of non-absolute RPATH reference to CoreFoundation
I'm taking a look to fix |
10 tasks
vigra is not yet compatible with the v1.12 API [0][1]. [0] ukoethe/vigra#476 [1] ukoethe/vigra#476
Introduce hdf5_1_10 so it can be used by packages encountering issues hdf5 1.12.0.
Without that, the test suite of python3Packages.pandas segfault.
Next iteration: #119398 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: fetch
6.topic: kernel
The Linux kernel
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
6.topic: ocaml
6.topic: python
6.topic: ruby
6.topic: rust
6.topic: systemd
8.has: module (update)
This PR changes an existing module in `nixos/`
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 501+
10.rebuild-darwin: 5001+
10.rebuild-darwin-stdenv
This PR causes stdenv to rebuild
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
10.rebuild-linux-stdenv
This PR causes stdenv to rebuild
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://hydra.nixos.org/job/nixpkgs/staging-next/unstable#tabs-constituents
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)