Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imagemagick: 7.0.11-3 -> 7.0.11-4 #117114

Merged
merged 1 commit into from
Mar 21, 2021
Merged

imagemagick: 7.0.11-3 -> 7.0.11-4 #117114

merged 1 commit into from
Mar 21, 2021

Conversation

erictapen
Copy link
Member

@erictapen erictapen commented Mar 21, 2021 •
edited
Loading

Changelog

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@erictapen erictapen added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 21, 2021
@erictapen erictapen requested a review from dotlambda March 21, 2021 11:45
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 labels Mar 21, 2021
@dotlambda
Copy link
Member

needs: port to stable

Why?

@erictapen
Copy link
Member Author

@dotlambda I figured that imagemagick receives so many security updates that we may want to keep it up to date on the stable release anyway. At least for minor version bumps like 7.0.11 -> 7.0.12.
Also upstream has the bad habit of not mentioning closed CVEs in the changelog (nor the commit messages), so imho it is too error prone to determine wether a release is security relevant or not.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 21, 2021 •
edited
Loading

Result of nixpkgs-review pr 117114 at 2a85dbd run on aarch64-linux 1

14 packages marked as broken and skipped:
  • asymptote
  • autotrace
  • devede
  • gnome3.gnome-documents
  • gopro
  • invoice2data
  • photoflow
  • split2flac
  • spring
  • springLobby
  • ...
161 packages skipped due to time constraints:
  • abiword
  • adapta-gtk-theme
  • arc-theme
  • arx-libertatis
  • asc-key-to-qr-code-gif
  • asciidoc-full
  • asciidoc-full-with-plugins
  • awesome (awesome-4-0)
  • beets
  • beetsExternalPlugins.alternatives
  • ...
12 packages built successfully:

Result of nixpkgs-review pr 117114 at 2a85dbd run on x86_64-linux 1

13 packages marked as broken and skipped:
  • autotrace
  • gimpPlugins.exposureBlend
  • gimpPlugins.texturize
  • glimpsePlugins.exposureBlend
  • glimpsePlugins.texturize
  • gnome3.gnome-documents
  • hhvm
  • invoice2data
  • spring
  • springLobby
  • ...
212 packages skipped due to time constraints:
  • abiword
  • adapta-gtk-theme
  • arc-theme
  • arx-libertatis
  • asc-key-to-qr-code-gif
  • asciidoc-full
  • asciidoc-full-with-plugins
  • asymptote
  • awesome (awesome-4-0)
  • beets
  • ...
15 packages built successfully:

@dotlambda dotlambda merged commit f53b98c into NixOS:staging Mar 21, 2021
@dotlambda
Copy link
Member

@erictapen Will you do the backport?

@erictapen
Copy link
Member Author

Backported in 4636ea6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erictapen @dotlambda @r-rmcgibbo