Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetchgit: escape dot in regex #111782

Merged
merged 1 commit into from
Mar 21, 2021
Merged

fetchgit: escape dot in regex #111782

merged 1 commit into from
Mar 21, 2021

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Feb 3, 2021

Motivation for this change

This regex should match files ending in .git, not any character and git after that.
Unfortunately, this tiny change will cause a massive rebuild, which is why I haven't tested it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Luflosi
fetchgit: escape dot in regex
e238ff0 
This regex should match files ending in `.git`, not any character and `git` after that.
@Luflosi
Copy link
Contributor Author

Luflosi commented Feb 3, 2021

Ok, for some reason, this seems to not cause a massive rebuild.

taku0
taku0 approved these changes Feb 13, 2021
View reviewed changes
Copy link
Contributor

@taku0 taku0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise LGTM.

@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000 SuperSandro2000 merged commit d6df2c3 into NixOS:staging Mar 21, 2021
@Luflosi Luflosi deleted the fetchgit-escape-regex branch March 21, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taku0 taku0 taku0 approved these changes

Assignees
No one assigned
Labels
6.topic: fetch 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Luflosi @SuperSandro2000 @taku0