Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kicad: 5.1.8 -> 5.1.9 #107467

Merged
merged 3 commits into from
Jan 7, 2021
Merged

Kicad: 5.1.8 -> 5.1.9 #107467

merged 3 commits into from
Jan 7, 2021

Conversation

evils
Copy link
Member

@evils evils commented Dec 23, 2020

Motivation for this change

new stable version tagged

Things done

fixed update.sh to handle multiple responses from git ls-remote --heads --tags (taking the last rather than the first response)
run update.sh to update stable and unstable

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • 8 packages updated: kicad-with-packages3d (5.1.8 → 5.1.9) kicad (5.1.8 → 5.1.9) python39Packages.kicad (5.1.8 → 5.1.9) python38Packages.kicad (5.1.8 → 5.1.9) python37Packages.kicad (5.1.8 → 5.1.9) kicad-small (5.1.8 → 5.1.9) kicad-unstable (2020-12-01 → 2020-12-23) kicad-unstable-small (2020-12-01 → 2020-12-23)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • stable: 6347308864 -> 6764336248
    • unstable: 6925383008 -> 6926087408
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107467 run on x86_64-darwin 1

5 packages marked as broken and skipped:
  • kicad-small
  • kicad-unstable-small
  • python37Packages.kicad
  • python38Packages.kicad
  • python39Packages.kicad

@evils
Copy link
Member Author

evils commented Dec 24, 2020

on x86_64-darwin

i believe until #98538 is merged, our kicad can't work on darwin

there's still a comment in default.nix calling out libngspice as linux only, but that has been fixed
i don't have a way of confirming that issue is actually resolved though

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107467 run on x86_64-linux 1

5 packages built:
  • kicad-small
  • kicad-unstable-small
  • python37Packages.kicad
  • python38Packages.kicad
  • python39Packages.kicad

@veprbl veprbl merged commit 0448f1c into NixOS:master Jan 7, 2021
@evils
Copy link
Member Author

evils commented Jan 8, 2021

ah yes, the traditional PR merge as i find an issue and start working on it :D

3D models in kicad-unstable don't work (this issue is not introduced in this PR)
the packages3d install path changed, to adjust this:
under preferences -> configure paths, change KISYS3DMOD from
kicad-packages3d-2020-12-23/share/kicad/modules/packages3d/
to
kicad-packages3d-2020-12-23/share/kicad/3dmodels/
(s/modules\/packages3d/3dmodels/)
a popup should warn you that this change is temporary, you'll have to re-do it every time you start kicad
or modify the package to use the new path in the wrapper
the newest kicad source has more advanced issues with 3D model paths (open issue) which i'm waiting to be resolved before opening a PR

@evils evils deleted the kicad-5.1.9 branch January 18, 2021 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants