Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing libsoup 2.4 #360897

Open
1 of 4 tasks
jtojnar opened this issue Dec 1, 2024 · 2 comments
Open
1 of 4 tasks

Removing libsoup 2.4 #360897

jtojnar opened this issue Dec 1, 2024 · 2 comments
Labels
0.kind: enhancement Add something new 1.severity: security Issues which raise a security issue, or PRs that fix one 3.skill: sprintable A larger issue which is split into distinct actionable tasks

Comments

@jtojnar
Copy link
Member

jtojnar commented Dec 1, 2024

Libsoup 2.4 ABI branch has been unsupported for a while now and security issues are popping up. We should work on getting rid of it.

Plan

  1. ✔️ Rename libsoup to libsoup_2_4.

  2. Walk though the packages still using the old version and replace it where possible.

    The problematic part is that in general, a program can only load one of the libraries or there will be symbol conflicts. So we need to make sure to replace it at the same time for all

    • dino – supports libsoup 3 but also uses libnice, which transitively depends on old libsoup
    • inkscape – does not appear to be used
    • libnice – depends on 2.4 through gnupg-igd-1_0, there is a stale MR to bump so we might need to use libsoup do it locally like Arch does
    • wxGTK32 pulls libsoup 2 through webkitgtk_4_0 (wxGTK depends on deprecated libsoup 2 #369710)
  3. Attempt to upgrade packages stuck with the old version upstream.

  4. After a while, remove the stuck packages.

@jtojnar jtojnar added 0.kind: enhancement Add something new 3.skill: sprintable A larger issue which is split into distinct actionable tasks labels Dec 1, 2024
@jtojnar jtojnar self-assigned this Dec 1, 2024
@SigmaSquadron SigmaSquadron added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Dec 2, 2024
@tomodachi94
Copy link
Member

tomodachi94 commented Dec 13, 2024

libnice is unmaintained(!!). Pinging dino maintainers @alyssais and @tomfitzhenry so they're aware.

@alyssais
Copy link
Member

I think the libnice MR probably needs to just be resubmitted by somebody else. It's a one character change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: enhancement Add something new 1.severity: security Issues which raise a security issue, or PRs that fix one 3.skill: sprintable A larger issue which is split into distinct actionable tasks
Projects
Status: To do
Development

No branches or pull requests

4 participants