Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker_27 update (27.0.2 -> 27.0.3) only includes cli hash, not moby package #327692

Closed
guoard opened this issue Jul 16, 2024 · 1 comment · Fixed by #327702
Closed

docker_27 update (27.0.2 -> 27.0.3) only includes cli hash, not moby package #327692

guoard opened this issue Jul 16, 2024 · 1 comment · Fixed by #327702
Labels
0.kind: bug Something is broken 9.needs: package (update) This needs a package to be updated

Comments

@guoard
Copy link
Contributor

guoard commented Jul 16, 2024

Describe the bug

In this PR, the docker_27 version was updated from 27.0.2 to 27.0.3, but only the hash of the CLI was updated, not the moby package.

How was this built? The hash for the moby version 27.0.3 should be sha256-xinRILDSuubAAJh/dmpaU3csTf0VgukJIfSUkcHpa28=.

Expected behavior

The value of the mobyHash variable in docker_27 should be updated.

Additional context

Here's how I installed Docker in my /etc/nixos/configuration.nix file:

  virtualisation.docker = {
    enable = true;
    package = unstable.docker_27;
    liveRestore = false;
  };

I'm not sure if it's relevant, but when I run the docker info command, I see this output:

Client:
 Version:    27.0.2

Server:
 Server Version: 27.0.3

This is odd because it should be the other way around!

Notify maintainers

@offline
@vdemeester
@periklis
@teutat3s

Metadata

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"

- system: `"x86_64-linux"`
- host os: `Linux 6.6.36, NixOS, 24.05 (Uakari), 24.05.2780.53e81e790209`
- multi-user?: `yes`
- sandbox: `yes`
- version: `nix-env (Nix) 2.18.4`
- channels(root): `"nixos-24.05, unstable"`
- nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos

Add a 👍 reaction to issues you find important.

@guoard guoard added the 0.kind: bug Something is broken label Jul 16, 2024
@eclairevoyant
Copy link
Contributor

eclairevoyant commented Jul 16, 2024

How was this built?

It's to do with how FODs work in nix and nixpkgs; this would be ultimately looked at in some PRs such as #294068. But we should also have the update script corrected (r-ryantm is an update bot).

@eclairevoyant eclairevoyant added the 9.needs: package (update) This needs a package to be updated label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken 9.needs: package (update) This needs a package to be updated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants