Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: interpolate src.rev into meta.changelog instead of version #299597

Open
lolbinarycat opened this issue Mar 27, 2024 · 4 comments
Open

Comments

@lolbinarycat
Copy link
Contributor

in the process of mass checking nixpkgs metadata url, i see a few very common classes of errors:

  1. pointing to blob/${version} instead of blob/v${version}
  2. switching from a stable to unstable versioning scheme, and not updating the changelog url
  3. using a more precise versioning scheme than the one used upstream for tags.

all of these would be fixed by interpolating src.rev (which will be either a commit or tag) instead of version (which often uses a nixpkgs-specific format)


Add a 👍 reaction to issues you find important.

@dotlambda
Copy link
Member

I agree. But this might not work if the changelog refers to GitHub release notes where refs/tags/v${version} doesn't work.

@lolbinarycat
Copy link
Contributor Author

hmm, fair point, although i think it should be fine to just not use the fully-qualified ref name in that case? just do rev = "v${version}"?

@lolbinarycat
Copy link
Contributor Author

although, release notes won't work for a commit either. maybe it would be better to just link to https://github.com/ORG/REPO/releases/ instead of trying to link to a specific release?

although, it will be much less important once nixpkgs metadata is tested automatically.

@Pandapip1
Copy link
Contributor

See related discussion at #336454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants