Mesa 21.0: VAAPI recording broken

[YellowOnion]

Describe the bug

VAAPI records repeated frames (see upstream bug report).

upstream fix: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9995

To Reproduce
Steps to reproduce the behavior:

1. ... open OBS
2. ... try recording using VAAPI (possible AMD hardware required?)
3. ... watch replay

Expected behavior
full FPS.

Notify maintainers

@primeos @vcunat

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

[vcunat]

As for 21.0, the fix is contained in upstream release >= 21.0.2 so e.g. PR #120325

[YellowOnion]

As for 21.0, the fix is contained in upstream release >= 21.0.2 so e.g. PR #120325

Sadly a look at that thread, it's blocked because something broke, and they're not pushing it to 21.05, so this bug is going to exist until someone figures this out the regression, this patch is only one line of code, maybe it can be supplied as a patch until they get 21.0.3 working?

Is there a way to build a patched mesa without rebuilding my entire desktop stack? It's currently stupidly slow on my computer when doing a packageOverride.

[FlorianFranzen]

This will not be the only bug people will have to deal with on 21.05 unless we backport a more recent mesa (>=21.1). Alternative we could also start to includes this patch as well.

Without it, this will lead to crashes in wine (incl. steam proton) when initializing a GL context on some hardware (GLXBadFBConfig for reference). While one can set MESA_GL_VERSION_OVERRIDE=4.5 as a workaround, it is hardly ideal and difficult to diagnose from within steam alone.

@NixOS/backports Would it be possible to backport the mesa update currently in staging-next (#124095) once it is merged?

[vcunat]

I don't know... this is hard. Maybe after a version has been a couple weeks in nixos-unstable, we might be sufficiently confident that it won't make things worse overall.

[jonringer]

I'm okay with backporting it, but probably as its own job set, just to get a better idea of regressions.

[vcunat]

I'm not afraid of build-time regressions in this case. Those would be easy (to find). And mesa isn't such a big rebuild now anyway.

[jonringer]

If it's been on unstable for a while, I guess I'm okay with it as well

[YellowOnion]

I guess we can close this now, I haven't noticed any problems recently.