From d791ddbb5ea5aa1c467cf0aedeb62cbf846f007a Mon Sep 17 00:00:00 2001 From: piegames Date: Mon, 22 Nov 2021 01:25:28 +0100 Subject: [PATCH 1/2] CODEOWNERS: Update teams --- .github/CODEOWNERS | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 7dc14a61cbaed..9b2a52e9ae605 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -6,6 +6,13 @@ # # For documentation on this file, see https://help.github.com/articles/about-codeowners/ # Mentioned users will get code review requests. +# +# IMPORTANT NOTE: in order to actually get pinged, commit access is required. +# This also holds true for GitHub teams. Since almost none of our teams have write +# permissions, you need to list all members of the team with commit access individually. +# We still add the team to the list next to its members, this helps keeping things +# in sync. (Put non team members before the team to distinguish them.) +# See https://github.com/NixOS/nixpkgs/issues/124085 for more details # This file /.github/CODEOWNERS @edolstra @@ -210,11 +217,11 @@ /pkgs/top-level/php-packages.nix @jtojnar @NixOS/php @aanderse @etu @globin @ma27 @talyz # Podman, CRI-O modules and related -/nixos/modules/virtualisation/containers.nix @NixOS/podman @zowoq -/nixos/modules/virtualisation/cri-o.nix @NixOS/podman @zowoq -/nixos/modules/virtualisation/podman.nix @NixOS/podman @zowoq -/nixos/tests/cri-o.nix @NixOS/podman @zowoq -/nixos/tests/podman.nix @NixOS/podman @zowoq +/nixos/modules/virtualisation/containers.nix @NixOS/podman @zowoq @adisbladis +/nixos/modules/virtualisation/cri-o.nix @NixOS/podman @zowoq @adisbladis +/nixos/modules/virtualisation/podman.nix @NixOS/podman @zowoq @adisbladis +/nixos/tests/cri-o.nix @NixOS/podman @zowoq @adisbladis +/nixos/tests/podman.nix @NixOS/podman @zowoq @adisbladis # Docker tools /pkgs/build-support/docker @roberth @utdemir From 565ceb25962760ec1d77217ff4ff9ea13a94b8f4 Mon Sep 17 00:00:00 2001 From: piegames Date: Mon, 22 Nov 2021 01:25:31 +0100 Subject: [PATCH 2/2] CODEOWNERS: Add entries for GNOME --- .github/CODEOWNERS | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 9b2a52e9ae605..719f61203d22a 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -237,6 +237,10 @@ /pkgs/development/go-modules @kalbasit @Mic92 @zowoq /pkgs/development/go-packages @kalbasit @Mic92 @zowoq +# GNOME +/pkgs/desktops/gnome @NixOS/GNOME @jtojnar @hedning +/pkgs/desktops/gnome/extensions @piegamesde @NixOS/GNOME @jtojnar @hedning + # Cinnamon /pkgs/desktops/cinnamon @mkg20001