SDV Health checks ignore some Collection installed mods

[Al12rs]

Bug Report

Summary

If a SDV mod is installed as part of a Collection using "Replicate" method, it will not have the extra SMAPILoadoutItem metadata, making the resulting mod invisible to health checks.

Details

Our normal SMAPIModInstaller adds metadata to Stardew Valley mods regarding their manifest. We use the this metadata to recognize mods with SMAPI manifests inside the health checks.

If a SMAPI mod is not installed through the SMAPIModInstaller, the extra metadata will not be added, making the mod invisible to the health checks.

Other information

We should either change health checks to find the relevant mods some other way, or make a system that can add metadata to any new mod, not just the ones using a particular installer.

[Pickysaurus]

@Al12rs Would this also be true of mods installed via "Advanced Install"?

[Al12rs]

@Al12rs Would this also be true of mods installed via "Advanced Install"?

Yes that is correct, mods installed that way don't currently have the extra metadata.

We should either implement a post installer step that can attach metadata, regardless of the installer used, or not rely on metadata at all in Health checks.

[Pickysaurus]

It's probably good to extract metadata as that basically caches it, right? I suppose there are possible cases where we want metadata refreshed, though. Such as if I edit the manifest.json of a mod. Or when we eventually support Bethesda games, I could resave the plugin with different masters.