Skip to content
This repository has been archived by the owner on Aug 5, 2024. It is now read-only.

Support partial app IDs #168

Open
lornajane opened this issue Aug 13, 2018 · 4 comments
Open

Support partial app IDs #168

lornajane opened this issue Aug 13, 2018 · 4 comments

Comments

@lornajane
Copy link
Contributor

Steps to reproduce

Looked at my apps: nexmo apps
Wondered which numbers were linked for a specific app: nexmo app:numbers .... then I typed a few characters of the start of the app ID. Turns out, you need the whole thing. Not very easy from CLI.

Expected behavior

We should only require enough characters to uniquely identify which app we mean - similar to what git does with revision numbers.

Actual behavior

I had to type all 36 characters despite only having 4 apps and no common starting strings between them.

@Ricool06
Copy link

Hey, @lornajane I'll give this a shot. 👍

@Ricool06
Copy link

Is it acceptable to make another API call to do this? From what I've read in the code, the only way to do this in this project alone is to retrieve a list of all apps, then fail if 0 or >1 app contains a partial match, and succeed if exactly 1 app ID partially matches the argument.

@AlexLakatos
Copy link
Contributor

Yes, that's acceptable.

@Ricool06
Copy link

Pull request is up, forgot to say. Feedback welcome 😁

AlexLakatos added a commit that referenced this issue Nov 19, 2018
adding partial app id match for 'nexmo an' #168
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants