Fixed bug for dimension of the pattern spectrum and set default parameter pvalue_spectrum to None in concept_output_to_patterns #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…corrected spectrum but wrong inizialization of the matrix) and set default parameter pvalue_spectrum to None concept_output_to_patterns and added related unit test
alperyeg
reviewed
Mar 22, 2018
| t_start (in bins) of the analyzed spike trains | ||
| pvalue_spectrum: None or tuple | ||
| Contains a tuple of signatures and the corresponding p-value. If equal | ||
| to None all the pvalues are set to -1 |
There was a problem hiding this comment.
In the comment below you write:
If an empty list is given in input to the pval spectrum the pvalue is set to -1 (pvalue spectrum not available)
but here you mention that all pvalues are set to -1. It doesn't match with the documentation here. I also see that the dictionary will have afterwards only one entry, -1
output_dict['pvalue'] = -1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug for dimension of the pattern spectrum and set default parameter pvalue_spectrum to None in concept_output_to_patterns corrected spectrum but wrong inizialization of the matrix) and set default parameter pvalue_spectrum to None concept_output_to_patterns and added related unit test