Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing starknet.js code #3

Open
jelilat opened this issue Jan 7, 2024 · 8 comments
Open

Add missing starknet.js code #3

jelilat opened this issue Jan 7, 2024 · 8 comments
Assignees

Comments

@jelilat
Copy link
Contributor

jelilat commented Jan 7, 2024

The following endpoints have missing starknet.js code

  • starknet_call
  • starknet_estimateFee
  • starknet_estimateMessageFee
  • starknet_addInvokeTransaction
  • starknet_addDeclareTransaction
  • starknet_addDeployAccountTransaction
  • starknet_simulateTransactions
@makluganteng
Copy link

Hi may i take this issue ?

@AryanGodara
Copy link

The following endpoints have missing starknet.js code

  • starknet_call
  • starknet_estimateFee
  • starknet_estimateMessageFee
  • starknet_addInvokeTransaction
  • starknet_addDeclareTransaction
  • starknet_addDeployAccountTransaction
  • starknet_simulateTransactions

Can you please go tell how to get started with this task; I have good experience writing APIs, but some more context would be really helpful to get started :D

@Blazing-Mike
Copy link

@makluganteng is it possible i take some of the methods. or you are done solving them. there are no js issues to solve.

@makluganteng
Copy link

Im all good no worries 🙏

@Blazing-Mike
Copy link

Alright.

@makluganteng
Copy link

makluganteng commented Feb 17, 2024

HI i have a question on the estimate fee , there are multiple type of transaction do i put into the same inside the starknet.js

// Estimate the fee for StarkNet transactions
  {
    name: "starknet_estimateFee",
    params: {
      request: [BROADCASTED_INVOKE_TXN], //TODO:
      simulation_flags: [
        {
          placeholder: "SKIP_VALIDATE",
          description:
            "Flags that indicate how to simulate a given transaction. By default, the sequencer behavior is replicated locally",
        },
      ],
      block_id,
    },
    starknetJs: `${STARKNET_JS_PREFIX} //here but im wondering how to differentiate the transaction here
    `,
    starknetGo: ``,
    starknetRs: ``,
  },```

@jelilat
Copy link
Contributor Author

jelilat commented Feb 17, 2024

HI i have a question on the estimate fee , there are multiple type of transaction do i put into the same inside the starknet.js

// Estimate the fee for StarkNet transactions
  {
    name: "starknet_estimateFee",
    params: {
      request: [BROADCASTED_INVOKE_TXN], //TODO:
      simulation_flags: [
        {
          placeholder: "SKIP_VALIDATE",
          description:
            "Flags that indicate how to simulate a given transaction. By default, the sequencer behavior is replicated locally",
        },
      ],
      block_id,
    },
    starknetJs: `${STARKNET_JS_PREFIX} //here but im wondering how to differentiate the transaction here
    `,
    starknetGo: ``,
    starknetRs: ``,
  },```

@makluganteng Not sure I fully understand your question. Can you please rephrase?

@makluganteng
Copy link

Sorry , so i saw there was multiple type of transaction and do we add that types of transaction on the code above ? or we need to make extra validation on the FE if its this type of transaction then there should be different code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants