Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handles reconnections in external signer #7535

Closed
anhnhgutech opened this issue Oct 1, 2024 · 0 comments · Fixed by #7649
Closed

Handles reconnections in external signer #7535

anhnhgutech opened this issue Oct 1, 2024 · 0 comments · Fixed by #7649
Assignees

Comments

@anhnhgutech
Copy link
Contributor

anhnhgutech commented Oct 1, 2024

Is your feature request related to a problem? Please describe.
For now, the SetupExternalSigner only happens once when the node starts.
If it fails, it won't be retried. This means the Clef must be ready before the node starts.

Related to: #6780

Describe the solution you'd like
I checked the flow of geth and nethermind, and I noted the same below:

  • geth
flowchart TD
	Start((Start)) --> InitConfiguration[Init Configuration]
	InitConfiguration --> ConnectToExternalSigner[Connect To External Signer]
	ConnectToExternalSigner --> IsConnectSuccess{{Is connect success?}}
	IsConnectSuccess --No --> ThrowError --> End((End))
	IsConnectSuccess --Yes--> ImportBlock[Sync data and import block]
	ImportBlock --> MineBlock[Mine block] --> End
	
Loading
  • nethermind
flowchart TD
	Start((Start)) --> InitConfiguration[Init Configuration]
	InitConfiguration --> ConnectToExternalSigner[Connect To External Signer]
	ConnectToExternalSigner --> IsConnectSuccess{{Is connect success?}}
	IsConnectSuccess --No --> SyncDataBlock[Sync data] --> End((End))
	IsConnectSuccess --Yes--> MineBlock[Sync data and mine block] --> End

Loading

In Nethermind, after a failed connection, the node continues running and syncing data without throwing an error. It also doesn't attempt to reconnect at this time. I think we should

  • Allow reconnection to the external signer, when the node starts and fails.
  • Or throw 1 error (exit with error code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants