Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra "?" in links #84

Closed
mestradanu opened this issue Apr 29, 2020 · 0 comments · Fixed by #103
Closed

Extra "?" in links #84

mestradanu opened this issue Apr 29, 2020 · 0 comments · Fixed by #103
Assignees
@mestradanu
Labels
bug Something isn't working.

Comments

@mestradanu
Copy link
Contributor

Looks like the start script is attaching an empty "?" string.

Add a check for an empty string (length 0) in the following block:

info-theme/src/js/theme/set-start-anchors.js

Line 7 in 4021e63

const starterQueryString = getStarterString();

@mestradanu mestradanu added the bug Something isn't working. label Apr 29, 2020
@mestradanu mestradanu self-assigned this Apr 29, 2020
This was referenced May 5, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mestradanu mestradanu

Labels
bug Something isn't working.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v2.3.0 NationalUniversitySystem/info-theme
1 participant
@mestradanu