Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: App Menu - add support for translated labels #755

Closed
christophercr opened this issue Oct 5, 2018 · 0 comments · Fixed by #759
Closed

ui: App Menu - add support for translated labels #755

christophercr opened this issue Oct 5, 2018 · 0 comments · Fixed by #759

Comments

@christophercr
Copy link
Collaborator

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[X] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

Currently it is not possible to add translation keys as the menu entry label. So they can't be localized.

Expected behavior

The AppMenu supports translation keys in the menu entry label which should be correctly translated into the different languages of the app.

Minimal reproduction of the problem with instructions

  • Add a translation key in the translations file.
  • Add such key to the menu entry label in the menu config

What is the motivation / use case for changing the behavior?

Make the menu localizable.

@christophercr christophercr added this to the 10.0.0-beta.1 milestone Oct 5, 2018
@christophercr christophercr changed the title ui: AppMenu - add support for translated labels ui: App Menu - add support for translated labels Oct 5, 2018
@christophercr christophercr self-assigned this Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant