Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: all - use RxJS latest and pipeable operators #258

Closed
dsebastien opened this issue Mar 15, 2018 · 4 comments
Closed

core: all - use RxJS latest and pipeable operators #258

dsebastien opened this issue Mar 15, 2018 · 4 comments

Comments

@dsebastien
Copy link
Contributor

dsebastien commented Mar 15, 2018

Goal: upgrade to the latest and greatest and try to take advantage of pipeable operators to improve our build size

Pipeable (also called "lettable") operators have been introduced in RxJS 5.5.0 and they provide a new way of composing observable chains.

Moreover, this new approach is more friendly with bundlers such as Webpack in order to automatically tree-shake the unused operators rather than being the developer manually taking care of not importing any operator that is not really needed.

We should move in this direction in order to get all the benefits of tree-shaking once we leverage it in Stark.

See https://blog.angularindepth.com/rxjs-understanding-lettable-operators-fe74dda186d3

Cfr

@dsebastien
Copy link
Contributor Author

This is critical for us to be able to tree shake our bundles correctly.
See https://github.com/ReactiveX/rxjs/blob/master/doc/pipeable-operators.md

While doing this we should:

  • get rid of our old RxJS operator imports
  • update packages/rollup.config.common-data.js to remove the obsolete globals

@dsebastien
Copy link
Contributor Author

Comment from @christophercr :
Apparently there is an issue when using the pipeable operators together with Scope Hoisting enabled (see ReactiveX/rxjs#2981).
Perhaps we should wait until the new major version of RxJS (v 6.0) is released to see if this is solved

@dsebastien
Copy link
Contributor Author

One more reason to move forward with this: ReactiveX/rxjs#3212

@christophercr christophercr self-assigned this Apr 3, 2018
@dsebastien dsebastien modified the milestones: must, 10.0.0-alpha.4 May 8, 2018
SuperITMan referenced this issue in SuperITMan/stark May 16, 2018
2.7.2

Adapt angular.json in each package. Adapt rollup config for Rxjs 6

ISSUES CLOSED: #359, #258, #19
@christophercr christophercr removed their assignment May 16, 2018
SuperITMan referenced this issue in SuperITMan/stark May 16, 2018
….7.2

Adapt angular.json in each package. Adapt rollup config for Rxjs 6

ISSUES CLOSED: #359, #258, #19
SuperITMan referenced this issue in SuperITMan/stark May 16, 2018
….7.2

Adapt angular.json in each package. Adapt rollup config for Rxjs 6

ISSUES CLOSED: #359, #258, #19
SuperITMan referenced this issue in SuperITMan/stark May 16, 2018
….7.2

Adapt angular.json in each package. Adapt rollup config for Rxjs 6

ISSUES CLOSED: #359, #258, #19
@christophercr
Copy link
Collaborator

Closed by #373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants