Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: services - should not export internal variables (serviceName) #1112

Closed
SuperITMan opened this issue Feb 4, 2019 · 0 comments · Fixed by #1113
Closed

ui: services - should not export internal variables (serviceName) #1112

SuperITMan opened this issue Feb 4, 2019 · 0 comments · Fixed by #1113

Comments

@SuperITMan
Copy link
Member

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[X] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

Currently, stark-ui exports starkAppSidebarServiceName, starkProgressIndicatorServiceName, etc.

Expected behavior

Only the InjectionToken of the services should be exported and not their name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant