-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fluid ads aren't restricted by parent width #123
Comments
Adding the following to - (void)layoutSubviews {
[super layoutSubviews];
if (GADAdSizeIsFluid(_bannerView.adSize)) {
_bannerView.frame = self.bounds;
}
} |
Looks like the native ad view code already has something like this: react-native-ad-manager/ios/RNAdManageNativeView.m Lines 56 to 61 in 38af969
So it should be easy enough to patch the banner ad view with it. I'll try to offer a PR with that, though the fastest method might be switch to the native ad view instead, since I believe it also supports banners? |
The native view doesn't conform to its parent, either, but not because the banner view doesn't, but because the view above that doesn't. |
Instead of using the banner with size fluid, I am using the nativeAdManager, and that has solved all of my problems. Hope this helps someone else. |
The FLUID ads always go to the screen width, and are not restricted by the parent container width. Has anyone found a solution to this problem?
The text was updated successfully, but these errors were encountered: