Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display gzip size of built assets #244

Merged
merged 1 commit into from
Oct 16, 2016
Merged

Display gzip size of built assets #244

merged 1 commit into from
Oct 16, 2016

Conversation

dting
Copy link
Contributor

@dting dting commented Oct 13, 2016

Resolves #57

tizmagik
tizmagik suggested changes Oct 14, 2016
View reviewed changes
package.json
@@ -53,6 +53,7 @@
"file-loader": "0.9.0",
"filesize": "3.3.0",
"glob": "7.1.0",
"gzip-size": "^3.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pin this at 3.0.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Sounds good.

@dting dting force-pushed the display-gzip-size branch 2 times, most recently from d6a5ccd to 365866a Compare October 14, 2016 04:50
ccpricenytimes
ccpricenytimes reviewed Oct 15, 2016
View reviewed changes
Copy link
Contributor

@ccpricenytimes ccpricenytimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dting thanks for taking care of this!

utils/printAssets.js
const stripAnsi = require('strip-ansi');
const logger = require('../cli/logger');

module.exports = (stats) => {
module.exports = (stats, clientConfig) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dting Make sure to pass clientConfig in here https://github.com/NYTimes/kyt/blob/master/cli/actions/build.js#L51

Copy link
Contributor Author

@dting dting Oct 15, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ccpricenytimes. I also checked to see that I didn't forget to change any other printAssets calls and updated the build.test.js for the updated the PR.

@dting dting force-pushed the display-gzip-size branch from 365866a to c3ae09a Compare October 15, 2016 23:29
@ccpricenytimes ccpricenytimes merged commit 1a15441 into nytimes:master Oct 16, 2016
@ccpricenytimes
Copy link
Contributor

thanks @dting !

delambo added a commit that referenced this pull request Oct 16, 2016
@delambo
Merge branch 'master' into adds-multiple-server-entry-handling
0e5308c 
* master:
  Display gzip size of built assets (#244)
  Adds newlines to log statements (#190)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccpricenytimes ccpricenytimes ccpricenytimes left review comments

@tizmagik tizmagik tizmagik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dting @ccpricenytimes @tizmagik