Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly check if the platform is supported #7444

Merged
merged 5 commits into from
Jan 4, 2023
Merged

Explicitly check if the platform is supported #7444

merged 5 commits into from
Jan 4, 2023

Conversation

cindyyuanjiang
Copy link
Collaborator

Resolves #7208

We added a GPU device compute capability check in RapidsExecutorPlugin, and throws an exception with a clear message if the GPU is unsupported.

@cindyyuanjiang
check gpu compute capability
7542abc 
Signed-off-by: Cindy Jiang <cindyj@nvidia.com>
@cindyyuanjiang
Merge branch 'branch-23.02' into check-platform-support
964fc7b
@cindyyuanjiang
remove previous debugging message
0d5a5cc 
Signed-off-by: Cindy Jiang <cindyj@nvidia.com>
@cindyyuanjiang cindyyuanjiang self-assigned this Dec 31, 2022
@cindyyuanjiang cindyyuanjiang added bug Something isn't working good first issue Good for newcomers labels Dec 31, 2022
@cindyyuanjiang
Copy link
Collaborator Author

build

jlowe
jlowe approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me. Is there a reason this is still in draft? If so, it would be good to mention why.

@cindyyuanjiang
Copy link
Collaborator Author

Change looks good to me. Is there a reason this is still in draft? If so, it would be good to mention why.

Thank you very much @jlowe! Not particularly, I will move this out of draft now.

@cindyyuanjiang cindyyuanjiang marked this pull request as ready for review January 3, 2023 20:04
@cindyyuanjiang cindyyuanjiang changed the title [WIP] Explicitly check if the platform is supported Explicitly check if the platform is supported Jan 3, 2023
@revans2 revans2 merged commit c36ef3e into NVIDIA:branch-23.02 Jan 4, 2023
@cindyyuanjiang cindyyuanjiang deleted the check-platform-support branch January 4, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

@revans2 revans2 revans2 approved these changes

Assignees

@cindyyuanjiang cindyyuanjiang

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Explicitly check if the platform is supported
3 participants
@cindyyuanjiang @jlowe @revans2