-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid using AST on inner joins and avoid coalesce after nested loop join filter #3746
Merged
abellina
merged 3 commits into
NVIDIA:branch-21.10
from
jlowe:fix-nested-inner-join-perf
Oct 5, 2021
Merged
Avoid using AST on inner joins and avoid coalesce after nested loop join filter #3746
abellina
merged 3 commits into
NVIDIA:branch-21.10
from
jlowe:fix-nested-inner-join-perf
Oct 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
build |
tgravescs
previously approved these changes
Oct 4, 2021
abellina
previously approved these changes
Oct 4, 2021
build |
Marking this as a draft until NDS performance runs are complete to verify there are no regressions. |
build |
abellina
approved these changes
Oct 5, 2021
NDS and cross join microbenchmark results on latest patch look good, marking this ready to merge. |
revans2
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3736.
@abellina and I looked into the nested loop join performance degradation and there were primarily two issues:
GpuFilterExec
extracted from the join in Add filter in query plan for conditional nested loop and cartesian joins #3105 was causing a subsequent batch coalesce to occur that wasn't there before. Traces showedcontiguous_split
was quite expensive on the post-join output for this query. Updating the post-join filter to not coalesce batches resulted in another approximate 4X speedup from the previous change.This updates nested loop joins to avoid using the AST if a post-filter can be used and also updates the post-filter injection code for joins to specify no coalesce after goal on the filter node.