Merge branch-25.02 to main [skip ci] #12219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add hybrid sha1 to mvn verify cache key. test run: https://github.com/YanxuanLiu/spark-rapids/actions/runs/13384970495/job/37379912782?pr=21#step:4:36 --------- Signed-off-by: Yanxuan Liu <yanxuanl@nvidia.com>
Wait for the pre-merge CI job to SUCCEED Signed-off-by: nvauto <70000568+nvauto@users.noreply.github.com>
…12205) this is a workaound for #12194 to unblock others before we figure out the root cause of the OOM issue ``` [2025-02-24T02:56:08.571Z] �[32mHostAllocSuite:�[0m [2025-02-24T02:56:08.571Z] �[33m- simple pinned tryAlloc !!! IGNORED !!! [2025-02-24T02:56:08.571Z] �[33m- simple non-pinned tryAlloc !!! IGNORED !!! [2025-02-24T02:56:08.571Z] �[33m- simple mixed tryAlloc !!! IGNORED !!! [2025-02-24T02:56:08.571Z] �[33m- simple pinned blocking alloc !!! IGNORED !!! [2025-02-24T02:56:08.571Z] �[33m- simple non-pinned blocking alloc !!! IGNORED !!! [2025-02-24T02:56:08.571Z] �[33m- simple mixed blocking alloc !!! IGNORED !!! [2025-02-24T02:56:08.571Z] �[33m- pinned blocking alloc with spill !!! IGNORED !!! [2025-02-24T02:56:08.571Z] �[33m- non-pinned blocking alloc with spill !!! IGNORED !!! [2025-02-24T02:56:08.571Z] �[33m- mixed blocking alloc with spill !!! IGNORED !!! ``` --------- Signed-off-by: Peixin Li <pxLi@nyu.edu>
This fixes #12211 The issue can only show up if we set the GPU concurrent value to be > 4, and we spill a lot. This should be rather rare, but it is possible to hit. This fix is to not let the blocking queue inside of the pool to actually block. That way we have control over when threads are woken up and when they are not. Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
Address gh-page pr comments #12185 We normally don't update gh-page pr directly, we file pr to dev branch(branch-25.02), and then merge dev branch to main, finally we merge main branch changes to gh-page branch. Signed-off-by: liyuan <yuali@nvidia.com>
|
build |
yinqingh
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to include latest doc updates
NOTE: this must be merged as
create a merge commit