Replicate HostColumnVector.ColumnBuilder in plugin to enable host memory oom work #10519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ory oom work Signed-off-by: Jim Brennan <jimb@nvidia.com>
|
build |
|
build |
|
RapidsHostColumnBuilder currently has copies of these cudf methods: |
|
pacakge-tests-scala213 (350,false) failure is unrelated, should be fixed by #10521. |
revans2
approved these changes
Mar 1, 2024
abellina
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help enable work on host memory oom handling in
GpuRowToColumnarIteratorfor feature #8887, this patch makes a copy of theHostColumnVector.ColumnBuilderclass in the plugin and replaces plugin uses ofColumnBuilderwith the new classRapidsHostColumnBuilder.I am putting this up as a draft to get feedback and consider whether we want to put this change in, or hold off until the rest of the work on
GpuRowToColumnarIteratoris completed.