Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Update CUDF host memory allocation APIs so allocation is pluggable. #9862

Open
revans2 opened this issue Nov 27, 2023 · 0 comments
Open
Assignees
Labels
reliability Features to improve reliability or bugs that severly impact the reliability of the plugin task Work required that improves the product but is not user facing

Comments

@revans2
Copy link
Collaborator

revans2 commented Nov 27, 2023

Is your feature request related to a problem? Please describe.
rapidsai/cudf#13924 added in a HostMemoryAllocator interface. But it also made using a non-default one on a per-API basis. This is what we wanted when I thought we could get memory limits without using the retry framework. After hitting some design issues it became clear that we have to use the retry framework for this. With that in mind we should just update the code so we have an API to set the default allocator use and that all allocations from java use that default allocator. We can either deprecate the per-API allocators or just remove them because I don't think that they are being used any more.

On the plugin side we will want to update the initialization code for HostAlloc to set this if there is a memory limit.

At the same time we can probably remove the reservation API from the pinned memory pool. It is not needed with the new design.

@revans2 revans2 added ? - Needs Triage Need team to review and classify task Work required that improves the product but is not user facing reliability Features to improve reliability or bugs that severly impact the reliability of the plugin labels Nov 27, 2023
@revans2 revans2 self-assigned this Nov 27, 2023
copy-pr-bot bot pushed a commit to rapidsai/cudf that referenced this issue Nov 28, 2023
spark-rapids requires the ability to set DefaultHostMemoryAllocator

Contributes to NVIDIA/spark-rapids#9862

Signed-off-by: Gera Shegalov <gera@apache.org>
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reliability Features to improve reliability or bugs that severly impact the reliability of the plugin task Work required that improves the product but is not user facing
Projects
None yet
Development

No branches or pull requests

2 participants