Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Support split and retry for project #7866

Open
revans2 opened this issue Mar 9, 2023 · 0 comments
Open

[FEA] Support split and retry for project #7866

revans2 opened this issue Mar 9, 2023 · 0 comments
Labels
reliability Features to improve reliability or bugs that severly impact the reliability of the plugin

Comments

@revans2
Copy link
Collaborator

revans2 commented Mar 9, 2023

Is your feature request related to a problem? Please describe.
#7864 provides basic retry functionality for project. This is great, but it does not allow for splitting the input. This was not done because splitting the input requires an API change where multiple output batches could be created. This is simplest to implement in terms of an Interator that wraps another Iterator that it reads from. This should be simple enough to integrate with GpuProjectExec, but it gets to be more complicated for other places where a project or filter are used. We don't have to update every place with these code changes, but it would be good to file follow on issues to look for more places we can/should update after this is done.

To be clear this is primarily to update GpuProjectExec to be able to do a split on the retry and to put changes in place that would allow others code paths to also do the same.

@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify labels Mar 9, 2023
@revans2 revans2 added the reliability Features to improve reliability or bugs that severly impact the reliability of the plugin label Mar 9, 2023
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Mar 21, 2023
@revans2 revans2 changed the title [FEA] Support split and retry for project/filter [FEA] Support split and retry for project May 17, 2023
@sameerz sameerz removed the feature request New feature or request label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reliability Features to improve reliability or bugs that severly impact the reliability of the plugin
Projects
None yet
Development

No branches or pull requests

3 participants