Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FOLLOW-UP] Refine error message for GpuSlice invalid cases. #12203

Open
ustcfy opened this issue Feb 24, 2025 · 0 comments
Open

[FOLLOW-UP] Refine error message for GpuSlice invalid cases. #12203

ustcfy opened this issue Feb 24, 2025 · 0 comments

Comments

@ustcfy
Copy link
Collaborator

ustcfy commented Feb 24, 2025

As a supplement to #12183

Currently when start and length are illegal, CpuSlice and GpuSlice can report errors separately, but the types of errors are different. The error type for GpuSlice needs to be modified to support the addition of assert_gpu_and_cpu_error tests.
@ustcfy ustcfy mentioned this issue Feb 24, 2025
Merged
@ustcfy ustcfy changed the title Add assertions for invalid start and length parameters in GpuSlice, as well as tests for CPU and GPU assertion errors. Add assertions for illegal start and length parameters in GpuSlice, as well as tests for CPU and GPU assertion errors. Feb 24, 2025
@res-life res-life changed the title Add assertions for illegal start and length parameters in GpuSlice, as well as tests for CPU and GPU assertion errors. [FOLLOW-UP] Refine error message for GpuSlice invalid cases. Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ustcfy