You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
GpuRaiseError currently uses GpuScalar.getValue to extract the value of errorParams from the GpuScalar argument in doColumnar(Int, GpuScalar, GpuScalar).
This might well be alright to do. All testing indicates that the Scalar has its host value set correctly.
However, if the host value isn't set, GpuScalar::getValue would use GpuScalar.extract to fetch the value. That method does not handle nested-type scalars correctly.
It would be worth investigating if that's a real possibility, and whether we should handle the map-scalar extraction differently.
The text was updated successfully, but these errors were encountered:
This is a follow-up task for #11969.
GpuRaiseError
currently usesGpuScalar.getValue
to extract the value oferrorParams
from theGpuScalar
argument indoColumnar(Int, GpuScalar, GpuScalar)
.This might well be alright to do. All testing indicates that the Scalar has its host value set correctly.
However, if the host value isn't set,
GpuScalar::getValue
would useGpuScalar.extract
to fetch the value. That method does not handle nested-type scalars correctly.It would be worth investigating if that's a real possibility, and whether we should handle the map-scalar extraction differently.
The text was updated successfully, but these errors were encountered: