Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

license header check has problems with deleted files #20

Closed
revans2 opened this issue Jan 17, 2025 · 1 comment · Fixed by #23
Closed

license header check has problems with deleted files #20

revans2 opened this issue Jan 17, 2025 · 1 comment · Fixed by #23
Assignees

Comments

@revans2
Copy link

revans2 commented Jan 17, 2025

A lot of recent builds have been failing with license header checks that are "wrong" but many if the files listed are files that were deleted.


--------- RESULT ---------
Following files missed copyright/license header or expired:
sql-plugin/src/main/scala/com/nvidia/spark/rapids/AlluxioCfgUtils.scala
sql-plugin/src/main/scala/com/nvidia/spark/rapids/AlluxioConfigReader.scala
sql-plugin/src/main/scala/com/nvidia/spark/rapids/AlluxioFS.scala
sql-plugin/src/main/scala/com/nvidia/spark/rapids/AlluxioUtils.scala
sql-plugin/src/main/scala/org/apache/spark/sql/execution/datasources/rapids/GpuPartitioningUtils.scala
sql-plugin/src/main/spark320/scala/org/apache/spark/sql/types/shims/PartitionValueCastShims.scala
sql-plugin/src/main/spark330/scala/org/apache/spark/sql/types/shims/PartitionValueCastShims.scala
sql-plugin/src/test/scala/com/nvidia/spark/rapids/AlluxioConfigReaderSuite.scala
sql-plugin/src/test/scala/com/nvidia/spark/rapids/AlluxioUtilsSuite.scala
sql-plugin/src/main/spark320/scala/com/nvidia/spark/rapids/shims/FileIndexOptionsShims.scala
sql-plugin/src/main/spark332db/scala/com/nvidia/spark/rapids/shims/FileIndexOptionsShims.scala

All of those files were deleted from the repo and cannot have a copyright that was updated.

@YanxuanLiu
Copy link
Collaborator

YanxuanLiu commented Jan 20, 2025

Hi @revans2, the cause of the failure is the workflow compared commit of feature branch and an very old commit of target branch. That's because the feature branch has not done an upmerge for a long time, it missed some recent commits of target branch. In your example, the unexpected files are deleted in these missed commits.

Actually we have a reminder in the log https://github.com/NVIDIA/spark-rapids/actions/runs/12824629012/job/35761088887#step:4:440 .

If there are files that are not modified by your PR, please try upmerge first.

Let me try to make the reminder more noticeable to avoid missing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants