Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed to find Thrust when compiling on conda-forge #843

Closed
benfred opened this issue Jun 21, 2023 · 1 comment · Fixed by rapidsai/rapids-cmake#431
Closed

Failed to find Thrust when compiling on conda-forge #843

benfred opened this issue Jun 21, 2023 · 1 comment · Fixed by rapidsai/rapids-cmake#431
Assignees
@robertmaynard

Comments

@benfred
Copy link
Member

benfred commented Jun 21, 2023

When building a conda package on conda-forge, I was seeing compile errors with thrust like :

CMake Error at _skbuild/linux-x86_64-3.10/cmake-build/_deps/thrust-src/thrust/cmake/thrust-config-version.cmake:4 (file):
    file failed to open for reading (No such file or directory):

      /home/conda/feedstock_root/build_artifacts/implicit_1686677296183/work/_skbuild/linux-x86_64-3.10/cmake-build/_deps/thrust-src/_THRUST_VERSION_INCLUDE_DIR-NOTFOUND/thrust/version.h

(from conda-forge/implicit-feedstock#56 )

@robertmaynard noticed that the thrust cmake files needed to be patched to handle this build environment, and need find_path(.... NO_CMAKE_FIND_ROOT_PATH) set for this to build here.

These changes to thrust benfred/thrust@8452c76 and cub benfred/cub@97934d1 caused the build on conda-forge to succeed - and these changes or similar should probably be applied here and in cub. For newer versions of thrust, we should also probably update https://github.com/nvidia/libcudacxx in a similar fashion -
benfred referenced this issue in benfred/implicit Jun 21, 2023
@benfred
Fix cuda build on conda-forge
f9dd69f 
The conda-forge build was failing to build on errors in finding thrust:
https://github.com/NVIDIA/thrust/issues/1966

Work around this issue by using a patched version of thrust/cub in the build
@benfred benfred mentioned this issue Jun 21, 2023
Merged
benfred referenced this issue in benfred/implicit Jun 21, 2023
@benfred
Fix cuda build on conda-forge (#668)
2b8ef2d 
* Fix cuda build on conda-forge

The conda-forge build was failing to build on errors in finding thrust:
https://github.com/NVIDIA/thrust/issues/1966

Work around this issue by using a patched version of thrust/cub in the build

* fix typo
@robertmaynard robertmaynard self-assigned this Jun 21, 2023
@robertmaynard robertmaynard mentioned this issue Jun 21, 2023
Closed
@robertmaynard
Copy link
Contributor

CUB: NVIDIA/cub#723
libcudacxx: NVIDIA/libcudacxx#490
thrust: NVIDIA/thrust#1969

robertmaynard referenced this issue in robertmaynard/rapids-cmake Jun 21, 2023
@robertmaynard
Correct re-root controls from conda-forge with thrust,cub, and libcud…
b0c7336 
…acxx

Upstream fix: https://github.com/NVIDIA/thrust/issues/1966
@robertmaynard robertmaynard mentioned this issue Jun 21, 2023
Merged
4 tasks
rapids-bot bot referenced this issue in rapidsai/rapids-cmake Jun 29, 2023
@robertmaynard
Correct re-root controls from conda-forge with thrust/cub/etc (#431)
052d184 
Upstream fix: https://github.com/NVIDIA/thrust/issues/1966

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #431
@github-project-automation github-project-automation bot moved this to Todo in CCCL Nov 8, 2023
@jarmak-nv jarmak-nv transferred this issue from NVIDIA/thrust Nov 8, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in CCCL Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertmaynard robertmaynard

Labels
None yet
Projects
CCCL
Archived in project
Milestone
No milestone
3 participants
@benfred @robertmaynard @jrhemstad