Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Add masking support to SequencePredictNext, SequencePredictLast, and SequencePredictRandom #1026

Closed
sararb opened this issue Mar 21, 2023 · 0 comments · Fixed by #1022
Labels
area/session-based enhancement New feature or request
Milestone

Comments

@sararb
Copy link
Contributor

sararb commented Mar 21, 2023

🚀 Feature request

The current sequence transforms - SequencePredictNext, SequencePredictLast, and SequencePredictRandom - don't generate _keras_mask information for inputs and targets. This is because these transforms extract the targets from the input sequence and return new truncated inputs that don't contain the target information.

However, the Model output API uses mask information to adjust the shape of predictions and targets. To ensure that the Model output API can work with all supported sequence transforms, we should add masking support to all sequence transforms and rely on the Model output API to align the model's predictions and targets accordingly.

This would ensure that the model output API can handle a range of sequence transforms and produce correct outputs, regardless of the specific transform used.

@sararb sararb added enhancement New feature or request area/session-based labels Mar 21, 2023
@sararb sararb added this to the Merlin 23.03 milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/session-based enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant