bug: metadata query param with : not being parsed correctly

[csmig]

GET endpoints which accept a metadata query parameter are not parsing that parameter correctly if the metadata value contains the colon character (:).

The API specification requires the metadata query parameter to be encoded as key:value. So if the key is cklWebDbSite and the value is 0.0.0.0:8080, the query parameter is encoded as cklWebDbSite:0.0.0.0:8080.

The API implementation handles the metadata query parameter like this:

stig-manager/api/source/service/AssetService.js

Line 210 in 2c56ce1

const [key, value] = pair.split(':')

This will not correctly recover value if it contains a colon. For the example above, it returns the value only up to the colon (0.0.0.0).

Affected endpoints:

• GET /collections
• GET /assets
• GET /collections/{collectionId}/reviews

The likely fix is to change the implementation to:

const [key, value] = pair.split(/:(.*)/s)