Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pvlib column labels for solar weather files #866

Closed
cpaulgilman opened this issue Dec 30, 2021 · 2 comments · Fixed by NREL/ssc#754
Closed

Allow pvlib column labels for solar weather files #866

cpaulgilman opened this issue Dec 30, 2021 · 2 comments · Fixed by NREL/ssc#754
Assignees

Comments

@cpaulgilman
Copy link
Collaborator

The variable name convention in the Python pvlib documentation is here:

https://pvlib-python.readthedocs.io/en/stable/variables_style_rules.html

SAM's weather file reader column names are defined here:

https://github.com/NREL/ssc/blob/632217258303cdbb77f471b517187b701f56d08e/shared/lib_weatherfile.cpp#L948

Modify lib_weatherfile.cpp to accept pvlib variable names.

@cpaulgilman
Copy link
Collaborator Author

SSC PR 754 should resolve this issue.

@williamhobbs, let me know if you know of other labels to add to this list:

poa_global, temp_air, temp_dew, wind_speed, wind_direction, relative_humidity

@williamhobbs
Copy link
Contributor

That looks like a complete list to me. Other variables (ghi, pressure, etc.) seem to already be covered.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants